Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo (LazyServiceIdentifer -> LazyServiceIdentifier) #1483

Merged
merged 5 commits into from
Sep 12, 2023
Merged

fix typo (LazyServiceIdentifer -> LazyServiceIdentifier) #1483

merged 5 commits into from
Sep 12, 2023

Conversation

unadlib
Copy link
Contributor

@unadlib unadlib commented Nov 9, 2022

Description

changes interface LazyServiceIdentifer name to LazyServiceIdentifier

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Updated docs / Refactor code / Added a tests case (non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the changelog.

@PodaruDragos
Copy link
Contributor

This look fine to me, we need to consider if this might break for users.

@unadlib
Copy link
Contributor Author

unadlib commented Nov 10, 2022

This look fine to me, we need to consider if this might break for users.

Maybe we can keep the original typo interface for now, also provide the interface with the correct name.

@Jameskmonger
Copy link
Member

@unadlib I agree, I would propose we keep the renaming (and use the new name internally also) but also export it under an alias of the old name

@PodaruDragos
Copy link
Contributor

We could also release a breaking version, which will include other breaking changes that might come, I'm ok either way.
I'll let you guys decide.

@unadlib
Copy link
Contributor Author

unadlib commented Nov 10, 2022

@unadlib I agree, I would propose we keep the renaming (and use the new name internally also) but also export it under an alias of the old name

OK. I have updated it. Please help review.

@codecov-commenter
Copy link

Codecov Report

Merging #1483 (d11fa7e) into master (01e5798) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1483      +/-   ##
==========================================
- Coverage   99.61%   99.56%   -0.06%     
==========================================
  Files          53       53              
  Lines        1566     1364     -202     
  Branches      205      196       -9     
==========================================
- Hits         1560     1358     -202     
  Partials        6        6
Impacted Files Coverage Δ
src/constants/error_msgs.ts 100.00% <ø> (ø)
src/annotation/lazy_service_identifier.ts 100.00% <100.00%> (ø)
src/inversify.ts 100.00% <100.00%> (ø)
src/planning/reflection_utils.ts 100.00% <100.00%> (ø)
src/container/container.ts 98.85% <0.00%> (-0.22%) ⬇️
src/planning/plan.ts 100.00% <0.00%> (ø)
src/planning/target.ts 100.00% <0.00%> (ø)
src/bindings/binding.ts 100.00% <0.00%> (ø)
src/container/lookup.ts 100.00% <0.00%> (ø)
src/planning/context.ts 100.00% <0.00%> (ø)
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@unadlib
Copy link
Contributor Author

unadlib commented Jan 21, 2023

hi, @Jameskmonger Can this MR be merged?

@Jameskmonger Jameskmonger changed the title fix typo about identifier fix typo (LazyServiceIdentifer -> LazyServiceIdentifier) Sep 12, 2023
@Jameskmonger Jameskmonger merged commit 0b4a689 into inversify:master Sep 12, 2023
20 checks passed
@Jameskmonger
Copy link
Member

Thank you for the contribution @unadlib, and apologies for the delay in getting this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jameskmonger Jameskmonger Jameskmonger approved these changes

@notaphplover notaphplover Awaiting requested review from notaphplover

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@unadlib @PodaruDragos @Jameskmonger @codecov-commenter